tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: My first to 7.x
Date Thu, 02 Dec 2010 22:24:32 GMT
On 02/12/2010 21:25, Christopher Schultz wrote:
> All,
> 
> So I'd like to apply my patch for bug (enhancement) 48692
> (https://issues.apache.org/bugzilla/show_bug.cgi?id=48692) to TC 7 trunk.
> 
> It's obvious to me how I should actually apply the patch: do an svn
> update, resolve any problems that arise (shouldn't be any) and commit
> what I've got to svn.
> 
> Then, should I update the changelog.xml?
Yes.

> Should my commit include that update?
Ideally, yes. Sometimes we forget and do it later.

> Should I update anything else?
Docs where appropriate.

> Notify anyone that I've done what I've done?
svn will do that for you by sending an e-mail to the dev list with the
diff of your change. No need for anything else.

> With Tomcat 7's CTR policy, I'm not just sure how to make sure that
> someone actually does the "R" part of the formula :)
The R happens when the svn diff gets sent to the dev list.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message