tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1051358 - in /tomcat/trunk/test/org/apache/tomcat/util/threads: DedicatedThreadExecutorTest.java TestCounterLatch.java
Date Tue, 21 Dec 2010 01:57:50 GMT
Author: markt
Date: Tue Dec 21 01:57:50 2010
New Revision: 1051358

URL: http://svn.apache.org/viewvc?rev=1051358&view=rev
Log:
Fix Checkstyle / Eclipse nags

Modified:
    tomcat/trunk/test/org/apache/tomcat/util/threads/DedicatedThreadExecutorTest.java
    tomcat/trunk/test/org/apache/tomcat/util/threads/TestCounterLatch.java

Modified: tomcat/trunk/test/org/apache/tomcat/util/threads/DedicatedThreadExecutorTest.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/threads/DedicatedThreadExecutorTest.java?rev=1051358&r1=1051357&r2=1051358&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/util/threads/DedicatedThreadExecutorTest.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/threads/DedicatedThreadExecutorTest.java Tue
Dec 21 01:57:50 2010
@@ -32,7 +32,7 @@ public class DedicatedThreadExecutorTest
                 dedicatedThread = Thread.currentThread();
                 DedicatedThreadExecutorTest.assertNotSame(testingThread,
                     dedicatedThread);
-                return 123L;
+                return Long.valueOf(123);
             }
         });
         assertEquals(123, result.longValue());
@@ -60,7 +60,7 @@ public class DedicatedThreadExecutorTest
                     dedicatedThread = Thread.currentThread();
                     DedicatedThreadExecutorTest.assertNotSame(testingThread,
                         dedicatedThread);
-                    return 456L;
+                    return Long.valueOf(456);
                 }
             });
         assertEquals(456, result.longValue());

Modified: tomcat/trunk/test/org/apache/tomcat/util/threads/TestCounterLatch.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/threads/TestCounterLatch.java?rev=1051358&r1=1051357&r2=1051358&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/util/threads/TestCounterLatch.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/threads/TestCounterLatch.java Tue Dec 21 01:57:50
2010
@@ -22,10 +22,7 @@ public class TestCounterLatch extends Te
 
     private volatile CounterLatch latch = null;
 
-    public void setUp() {
-
-    }
-
+    @Override
     public void tearDown() {
         CounterLatch temp = latch;
         if (temp!=null) temp.releaseAll();
@@ -41,6 +38,7 @@ public class TestCounterLatch extends Te
         latch = new CounterLatch(0,1);
         assertEquals("No threads should be waiting", false, latch.hasQueuedThreads());
         Thread testThread = new Thread() {
+            @Override
             public void run() {
                 try {
                     latch.await();
@@ -61,6 +59,7 @@ public class TestCounterLatch extends Te
         latch = new CounterLatch(0,1);
         assertEquals("No threads should be waiting", false, latch.hasQueuedThreads());
         Thread testThread = new Thread() {
+            @Override
             public void run() {
                 try {
                     latch.await();
@@ -82,6 +81,7 @@ public class TestCounterLatch extends Te
         latch = new CounterLatch(1,0);
         assertEquals("No threads should be waiting", false, latch.hasQueuedThreads());
         Thread testThread = new Thread() {
+            @Override
             public void run() {
                 try {
                     //System.out.println("Entering ["+Thread.currentThread().getName()+"]");
@@ -105,6 +105,7 @@ public class TestCounterLatch extends Te
         latch = new CounterLatch(1,0);
         assertEquals("No threads should be waiting", false, latch.hasQueuedThreads());
         Thread testThread = new Thread() {
+            @Override
             public void run() {
                 try {
                     latch.await();



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message