tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve
Date Mon, 20 Dec 2010 19:50:33 GMT

--- Comment #9 from Jim Riggs <> 2010-12-20 14:50:27 EST ---
Created an attachment (id=26428)
 --> (

Here is a first pass at this.  I have done rudimentary testing of both the
valve and filter.  Both appear to be working correctly, but it would be good if
someone with a real-life test/dev setup could run it through the gauntlet.

I tried to make as few changes as possible.  Effectively, all this patch does
is concatenate multiple headers into a single comma-delimited string before
passing it off to commaDelimitedListToStringArray().  Then processing continues
as it did before.

Note that this only addresses the remoteIpHeader (e.g. X-Forwarded-For).  It
does not do anything with proxiesHeader or protocolHeader.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message