tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1050504 - in /tomcat/trunk/java/org/apache/juli/logging: DirectJDKLog.java LogFactory.java
Date Fri, 17 Dec 2010 22:09:28 GMT
Author: markt
Date: Fri Dec 17 22:09:28 2010
New Revision: 1050504

URL: http://svn.apache.org/viewvc?rev=1050504&view=rev
Log:
Fix remaining Eclipse warnings in o.a.juli

Modified:
    tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java
    tomcat/trunk/java/org/apache/juli/logging/LogFactory.java

Modified: tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java?rev=1050504&r1=1050503&r2=1050504&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java (original)
+++ tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java Fri Dec 17 22:09:28 2010
@@ -71,74 +71,92 @@ class DirectJDKLog implements Log {
         logger=Logger.getLogger(name);        
     }
     
+    @Override
     public final boolean isErrorEnabled() {
         return logger.isLoggable(Level.SEVERE);
     }
     
+    @Override
     public final boolean isWarnEnabled() {
         return logger.isLoggable(Level.WARNING); 
     }
     
+    @Override
     public final boolean isInfoEnabled() {
         return logger.isLoggable(Level.INFO);
     }
     
+    @Override
     public final boolean isDebugEnabled() {
         return logger.isLoggable(Level.FINE);
     }
     
+    @Override
     public final boolean isFatalEnabled() {
         return logger.isLoggable(Level.SEVERE);
     }
     
+    @Override
     public final boolean isTraceEnabled() {
         return logger.isLoggable(Level.FINER);
     }
     
+    @Override
     public final void debug(Object message) {
         log(Level.FINE, String.valueOf(message), null);
     }
     
+    @Override
     public final void debug(Object message, Throwable t) {
         log(Level.FINE, String.valueOf(message), t);
     }
     
+    @Override
     public final void trace(Object message) {
         log(Level.FINER, String.valueOf(message), null);
     }
     
+    @Override
     public final void trace(Object message, Throwable t) {
         log(Level.FINER, String.valueOf(message), t);
     }
     
+    @Override
     public final void info(Object message) {
         log(Level.INFO, String.valueOf(message), null);
     }
     
+    @Override
     public final void info(Object message, Throwable t) {        
         log(Level.INFO, String.valueOf(message), t);
     }
     
+    @Override
     public final void warn(Object message) {
         log(Level.WARNING, String.valueOf(message), null);
     }
     
+    @Override
     public final void warn(Object message, Throwable t) {
         log(Level.WARNING, String.valueOf(message), t);
     }
     
+    @Override
     public final void error(Object message) {
         log(Level.SEVERE, String.valueOf(message), null);
     }
     
+    @Override
     public final void error(Object message, Throwable t) {
         log(Level.SEVERE, String.valueOf(message), t);
     }
     
+    @Override
     public final void fatal(Object message) {
         log(Level.SEVERE, String.valueOf(message), null);
     }
     
+    @Override
     public final void fatal(Object message, Throwable t) {
         log(Level.SEVERE, String.valueOf(message), t);
     }    

Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/logging/LogFactory.java?rev=1050504&r1=1050503&r2=1050504&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/juli/logging/LogFactory.java (original)
+++ tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Fri Dec 17 22:09:28 2010
@@ -321,11 +321,10 @@ public /* abstract */ class LogFactory {
      *
      * @param classLoader ClassLoader for which to release the LogFactory
      */
-    public static void release(
-            @SuppressWarnings("unused") ClassLoader classLoader) {
-        // JULI's log manager looks at the current classLoader, the default
-        // implementation does not so calling reset in that case will break
-        // things
+    public static void release(ClassLoader classLoader) {
+        // JULI's log manager looks at the current classLoader so there is no
+        // need to use the passed in classLoader, the default implementation
+        // does not so calling reset in that case will break things
         if (!LogManager.getLogManager().getClass().getName().equals(
                 "java.util.logging.LogManager")) {
             LogManager.getLogManager().reset();



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message