tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1041448 - in /tomcat/trunk: java/org/apache/catalina/mbeans/ContainerMBean.java webapps/docs/changelog.xml
Date Thu, 02 Dec 2010 16:51:08 GMT
Author: markt
Date: Thu Dec  2 16:51:08 2010
New Revision: 1041448

URL: http://svn.apache.org/viewvc?rev=1041448&view=rev
Log:
Correct removal of LifeCycleListenters from Containers via JMX.
Found with FindBugs

Modified:
    tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java?rev=1041448&r1=1041447&r2=1041448&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java Thu Dec  2 16:51:08 2010
@@ -263,7 +263,7 @@ public class ContainerMBean extends Base
         
         LifecycleListener[] listeners = container.findLifecycleListeners();
         for(LifecycleListener listener: listeners){
-            if(listener.getClass().equals(type)){
+            if(listener.getClass().getName().equals(type)){
                 container.removeLifecycleListener(listener);
             }
         }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1041448&r1=1041447&r2=1041448&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Dec  2 16:51:08 2010
@@ -83,6 +83,10 @@
       <fix>
         Correct handling of versioned web applications in deployer. (markt)
       </fix>
+      <fix>
+        Correct removal of <code>LifeCycleListenter</code>s from
+        <code>Container</code>s via JMX. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message