tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50025] getConnection method in class DataSourceProxy is ignoring credentials
Date Wed, 01 Dec 2010 20:10:20 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50025

--- Comment #4 from Filip Hanik <fhanik@apache.org> 2010-12-01 15:10:14 EST ---
hi Tim, this isn't really a bug, but how the pool operates.
This is a pool, meaning it caches connections with a predefined set of
credentials as defined in the configuration.

If we allowed the username/password to be passed, the cache would have to be
way more sophisticated, since it could mean that we would have to close a
connection, and open a new one with the provided credentials. 

So in the worst case scenario, you'd really not have a pool.

I started working on a simple patch, that would simply reuse the existing
cache, and see if the connection had the requested credentials already.
This way, the speed is not compromised on the cache, but could lead to
unnecessary disconnect/reconnects.

I can show you the patch, attached. (just needs some additional calls to
complete it)

But my gut feel, is that this isn't really a bug. If implemented as a feature,
it would need some serious though to not compromise the performance of the
existing implementation.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message