Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 37487 invoked from network); 11 Nov 2010 12:52:23 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Nov 2010 12:52:23 -0000 Received: (qmail 86593 invoked by uid 500); 11 Nov 2010 12:52:54 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 86495 invoked by uid 500); 11 Nov 2010 12:52:53 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 86486 invoked by uid 99); 11 Nov 2010 12:52:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Nov 2010 12:52:52 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=10.0 tests=ALL_TRUSTED,FS_REPLICA X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Nov 2010 12:52:50 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 9402F23889C5; Thu, 11 Nov 2010 12:51:35 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1033920 - in /tomcat/trunk: java/org/apache/catalina/tribes/transport/bio/BioReceiver.java java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java webapps/docs/changelog.xml Date: Thu, 11 Nov 2010 12:51:35 -0000 To: dev@tomcat.apache.org From: markt@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20101111125135.9402F23889C5@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: markt Date: Thu Nov 11 12:51:35 2010 New Revision: 1033920 URL: http://svn.apache.org/viewvc?rev=1033920&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50183 BIO sender was not scheduling tasks to the executor during normal operation. Patch provided by Ariel. Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java?rev=1033920&r1=1033919&r2=1033920&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java Thu Nov 11 12:51:35 2010 @@ -152,6 +152,7 @@ public class BioReceiver extends Receive socket.setSoTimeout(getTimeout()); ObjectReader reader = new ObjectReader(socket); task.serviceSocket(socket,reader); + getExecutor().execute(task); }//while } Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java?rev=1033920&r1=1033919&r2=1033920&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java Thu Nov 11 12:51:35 2010 @@ -65,7 +65,7 @@ public class BioReplicationTask extends try { drainSocket(); } catch ( Exception x ) { - log.error("Unable to service bio socket"); + log.error("Unable to service bio socket", x); }finally { try {socket.close();}catch ( Exception e){/* Ignore */} try {reader.close();}catch ( Exception e){/* Ignore */} @@ -80,7 +80,6 @@ public class BioReplicationTask extends public synchronized void serviceSocket(Socket socket, ObjectReader reader) { this.socket = socket; this.reader = reader; - this.notify(); // awaken the thread } protected void execute(ObjectReader reader) throws Exception{ Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1033920&r1=1033919&r2=1033920&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Thu Nov 11 12:51:35 2010 @@ -183,9 +183,13 @@ (kfujino) + 50183: BIO sender was not scheduling tasks to the executor + during normal operation. Patch provided by Ariel. (markt) + + 50184: Add an option to the RpcChannel to enable the Channel send options to be set for the reply message. Based on a patch by Ariel. - (markt)) + (markt) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org