tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Objections about formatting options to time stamp in access log
Date Thu, 11 Nov 2010 06:20:36 GMT
2010/11/11 Rainer Jung <rainer.jung@kippdata.de>:
> On 10.11.2010 04:38, sebb wrote:
>>
>> The private static fields timezone and timeZone[No]DST are not final,
>> but appear to be shared between threads.
>> The method that creates them is synchronised, but methods that read
>> them don't appear to be.
>> It would be safer to make these fields final and create them in a
>> static block (or equivalent).
>
> Thanks, done. Updated patch at:
>
> http://people.apache.org/~rjung/patches/tomcat-trunk-accesslog-extended-timestamp-v2.patch
>

Looks interesting.

> buf.append(Long.toString(...))

won't produce leading zeros

> The addElement() in the interface isn't very helpful.

If there is a need to change the AccessLogElement interface, I think
that can be done. We already changed it between TC6 and TC7
(StringBuffer -> StringBuilder).


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message