tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject ContainerBase @trunk (Re: r1029527)
Date Tue, 16 Nov 2010 15:44:00 GMT
I saw the following fragment in ContainerBase.logName():
Lines 1277-1278:

 	} else if (name.startsWith("##")) {
  	   name = "/" + name;
        }

It was added by
http://svn.apache.org/viewvc?view=revision&revision=1029527

Shouldn't it be
name = "/" + name.substring(2);

Anyway,
1) I am not sure that logging categories should depend on versioning.
It would be hard to configure logging across different versions of the webapp.

I do not mind though if version will be a subcategory (a suffix
separated by a dot).

2) This code is in a loop that iterates over parents of a context. So
the name can belong to a host or an engine. (Though unlikely anyone
will name them like that, so actually I do not bother about this).


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message