tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1035699 - in /tomcat/trunk: java/org/apache/catalina/session/ManagerBase.java test/org/apache/catalina/session/Benchmarks.java
Date Tue, 16 Nov 2010 17:47:17 GMT
On 16/11/2010 17:33, Remy Maucherat wrote:
> On Tue, 2010-11-16 at 17:13 +0000, markt@apache.org wrote:
>> URL: http://svn.apache.org/viewvc?rev=1035699&view=rev
>> Log:
>> Session manager performance
>> Narrow sync - few % improvement
>> -     *  1 thread  -  2,422ms
>> -     *  2 threads -  5,047ms
>> -     *  4 threads - 13,188ms
>> -     * 16 threads - 54,422ms
>> +     *  1 thread  -  ~2,400ms
>> +     *  2 threads -  ~4,700ms
>> +     *  4 threads - ~12,600ms
>> +     * 16 threads - ~53,700ms
> 
> Hmm, not very significant.

On its own, no. With some of the other changes it starts to look rather
better (I have a much more significant one for Windows coming up). I
need to repeat these tests on Linux / OSX.

> I knew about the relatively low session creation performance, but unless
> there's a secure way to remove the sync on getRandomBytes, there's no
> way to improve this. Having multiple (= thread local) random sources is
> probably not a good idea.

I thought of that but didn't like it either. See r1035701 for what I
think is a better approach.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message