tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [PATCH] Parallel deployment
Date Mon, 08 Nov 2010 14:31:02 GMT
On 06/11/2010 13:00, Rainer Jung wrote:
> On 06.11.2010 12:57, Tim Funk wrote:
>> When running mod_jk with sticky session, but not using tomcat clustering
>> ... Will adding a new version append the version number to the end of
>> the session cookie AFTER the engineId (used by mod_jk for determining
>> where to route the request)
> 
> Tried it and the jvmRoute comes last. Since it is likely that people put
> dots into the webappVersion, I'll add a loop to mod_jk that keeps
> looking for dots if it can't match the worker name to something it knows.

We might be able to avoid that be limiting the version to just integers.
I think that is reasonable but would like to hear some feedback from others.

That does raise the issue of whether to convert the provided version to
a (zero padded) string and continue with String compares or to convert
the version parsed from the session ID to an int. Performance is the
thing that worries me but I might be over-thinking this. Some
micro-benchmarks are probably called for.

>> Since the session id tomcat generates is always all uppercase. Should
>> the 'V' for the append be a lower case v? Even though session id
>> collision is *rare*, but using a char that isn't in the session id name
>> space would eliminate that problem.
> 
> The ids are actualy hex, so "V" is safe at least concrning ur own id
> generators. Nevertheless I also wonder whether a more obvious character
> would make it easier to understand (like "-" or "_"). Of course we are
> not safe from collissions with webappVersion characters or jvmRoute
> characters.

Indeed. Hence my thoughts around integers.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message