tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <>
Subject Re: [PATCH] Parallel deployment
Date Mon, 08 Nov 2010 14:27:57 GMT
On 06/11/2010 11:57, Tim Funk wrote:
> This might cause a problem of using == instead of equals() for strcmp
> if (version == (request.getContext().getWebappVersion())) {
>     mapRequired = false;
> }

Yep - that looks like a left-over from when I was playing with int
rather than String for version. I'm still in two minds about that bit.
There are places internally where using String makes it easier but
limiting it to int would allow us to avoid a bunch of issues.

> When running mod_jk with sticky session, but not using tomcat clustering
> ... Will adding a new version append the version number to the end of
> the session cookie AFTER the engineId (used by mod_jk for determining
> where to route the request)

Should be <sessionID>V<version>.jvmRoute

> Since the session id tomcat generates is always all uppercase. Should
> the 'V' for the append be a lower case v? Even though session id
> collision is *rare*, but using a char that isn't in the session id name
> space would eliminate that problem.

V was chosen since it isn;t a valid HEX digit.

> Otherwise +1. For those who are uninterested in the feature, it appears
> the extra overhead is minimal. (Some micro benchmarks would be nice for
> any skeptics ... or those just curious :) )



To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message