tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <>
Subject Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Date Mon, 01 Nov 2010 14:20:12 GMT
On 11/1/2010 5:58 AM, Mark Thomas wrote:
> On 01/11/2010 06:43, Konstantin Kolinko wrote:
>> 2010/11/1 Mark Thomas <>:
>>> On 31/10/2010 13:13, wrote:
>>>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
>>>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
>>>> +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Oct 31 17:13:51 2010
>>>> @@ -230,12 +230,14 @@ PATCHES PROPOSED TO BACKPORT:
>>>>    Allow 32-bit and 64-bit JDKs to be selected on 64-bit platforms
>>>>    +1: markt, mturk
>>>> -  -1:
>>>> +  -1: kkolinko: The function checkJava spawns a .bat file
>>>> +   (ExecWait '"$R0.bat"'). It is visible as a flickering black window
>>>> +   when I go from JRE selection page to the next page in TC7 installer.
>>>>     kkolinko: merging r1027504 does not perform cleanly
>>> The not merging cleanly I can fix when I get a moment. The briefly
>>> displayed command window is trickier. I don't know if it can be hidden.
>>> I certainly see it happen reasonably frequently when I install all sorts
>>> of Windows software. At the moment, I view it as a necessary evil for
>>> being able to support installing to 32-bit JVMs on 64-bit platforms.
>>> If Garrett (the MS open source guy) is at ApacheCon I'll try and pester
>>> him to see if there is a better way (e.g. looking for a magic number in
>>> a .exe or .dll). If anyone has any better ideas please speak up.

Some of this lives in apr_thread_proc.c for win32 in apr.  Will be happy
to offer pointers when I arrive.

>> Some thoughts:
>> 1. We do not need this check at all on a 32-bit OS.
> Yep. Should be possible to avoid this check on a 32-bit OS.

I wouldn't, some people will pre-stage things on a 32 bit machine to prepare
for mass copy to 64 bits.  Odd edge case but one to consider.

>> 3. I found the following:
>> [1]
>> mentions System.Reflection.Module.GetPEKind
> That requires .NET and not every machine has installed the .NET runtime.
> I don't want to make having .NET a pre-requisite for a correctly
> operating installer.

Hmmm, I believe every now-current version does have some minimum level of both
vbscript, wsh script and .net.

There is a way to do this in C that is pretty straightforward.  The choice
could easily be propagated to the microsoft system installer (MSI), but you
do get into the scenario where both JVMs are installed on a machine.
Fortunately these are not side by side as on solaris and similar.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message