tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Recycling processors in Http11NioProtocol
Date Thu, 14 Oct 2010 08:40:42 GMT
2010/10/14 Mark Thomas <markt@apache.org>:
> On 14/10/2010 01:01, Konstantin Kolinko wrote:
>> Hi!
>>
>> Looking at the Http11NioProtocol.Http11ConnectionHandler.release(NioChannel
>> socket) method in Http11NioProtocol.java,  it looks for me that like
>> that method does in all other places before any call to
>> "recycledProcessors.offer(result);" there should be
>>  - a call to connections.remove(socket)
>>  - a call to Http11NioProcessor.recycle()
>>
>> I see two places where those calls are missing.  A patch is inline
>> below,  as well as attached to the message. Any comments? I might miss
>> something.
>
> +1 for applying.
>
> Mark

Thank you for review.
Applied in r1022415, proposed for 6.0.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message