Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 69222 invoked from network); 28 Sep 2010 09:41:50 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Sep 2010 09:41:50 -0000 Received: (qmail 43820 invoked by uid 500); 28 Sep 2010 09:41:49 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 43409 invoked by uid 500); 28 Sep 2010 09:41:46 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 43347 invoked by uid 99); 28 Sep 2010 09:41:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Sep 2010 09:41:45 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of wesley.acheson@gmail.com designates 209.85.216.180 as permitted sender) Received: from [209.85.216.180] (HELO mail-qy0-f180.google.com) (209.85.216.180) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Sep 2010 09:41:37 +0000 Received: by qyk5 with SMTP id 5so11914056qyk.18 for ; Tue, 28 Sep 2010 02:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=06e70Yz9JSCBG58wvD23EuT4CTtPEsIRYen7zA5GklM=; b=Kk4hhr+ibgv4ig9XIIlGgb+FOAt6rjGcDDiruOagojMyNlcjvidHvVsdtEUR1hzbBH /LYP6ejsURHr/zBXYrVPwJtIT0meSrql+mAM2TAMK9Gwsm2zdrO9nLPcVv4S5riqj4Vw MKROagPBWFt1F/Ha9fD5e1OAC5koWybtSLjIo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=bO3JC2OEYOrH2FBrMJYrb/5CAi0BH5OAxf17qtH9VQqhjnDjvmxrHbeDdUFQkpSC2T cjbJ9JnvlkoGXPDWQRKIxB6xqsRk53sZDhyygEJGfNJdjYkADbEW33nNwaYB4EbOE+An NwnsWR6A9TXb1sx2hqt7ScmgTC8C9cGEFS1io= MIME-Version: 1.0 Received: by 10.229.189.6 with SMTP id dc6mr6835881qcb.54.1285666876442; Tue, 28 Sep 2010 02:41:16 -0700 (PDT) Received: by 10.229.48.70 with HTTP; Tue, 28 Sep 2010 02:41:16 -0700 (PDT) In-Reply-To: <20100928093608.D6E8B23889BB@eris.apache.org> References: <20100928093608.D6E8B23889BB@eris.apache.org> Date: Tue, 28 Sep 2010 11:41:16 +0200 Message-ID: Subject: Re: svn commit: r1002073 - in /tomcat/trunk: ./ res/ide-support/ res/ide-support/eclipse/ webapps/docs/ From: Wesley Acheson To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Sep 28, 2010 at 11:36 AM, wrote: > Author: timw > Date: Tue Sep 28 09:36:08 2010 > New Revision: 1002073 > > URL: http://svn.apache.org/viewvc?rev=3D1002073&view=3Drev > Log: > Moved all Eclipse specific files into res/ide-support/eclipse. > Removed spaces from launch target filenames. > Corrected launch targets to run in output/build instead of root directory= (still not sure if they're a good idea) > Added an Ant ide-eclipse target to prepare the working copy to be built w= ith Eclipse and create Eclipse project files. > Updated the Building docs to document new Eclipse setup method. > Added descriptions of how to configure Eclipse to respect Tomcat coding c= onventions to the Building guide. > > Added: > =A0 =A0tomcat/trunk/res/ide-support/ > =A0 =A0tomcat/trunk/res/ide-support/eclipse/ > =A0 =A0tomcat/trunk/res/ide-support/eclipse/eclipse.classpath > =A0 =A0 =A0- copied unchanged from r1001386, tomcat/trunk/eclipse.classpa= th > =A0 =A0tomcat/trunk/res/ide-support/eclipse/eclipse.project > =A0 =A0 =A0- copied unchanged from r1001386, tomcat/trunk/eclipse.project > =A0 =A0tomcat/trunk/res/ide-support/eclipse/start-tomcat.launch > =A0 =A0 =A0- copied, changed from r1001386, tomcat/trunk/Start Tomcat.lau= nch > =A0 =A0tomcat/trunk/res/ide-support/eclipse/stop-tomcat.launch > =A0 =A0 =A0- copied, changed from r1001386, tomcat/trunk/Stop Tomcat.laun= ch > Removed: > =A0 =A0tomcat/trunk/Start Tomcat.launch > =A0 =A0tomcat/trunk/Stop Tomcat.launch > =A0 =A0tomcat/trunk/eclipse.classpath > =A0 =A0tomcat/trunk/eclipse.project > Modified: > =A0 =A0tomcat/trunk/build.xml > =A0 =A0tomcat/trunk/webapps/docs/building.xml > > Modified: tomcat/trunk/build.xml > URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=3D1002073&r1= =3D1002072&r2=3D1002073&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- tomcat/trunk/build.xml (original) > +++ tomcat/trunk/build.xml Tue Sep 28 09:36:08 2010 > @@ -1513,6 +1513,7 @@ Apache Tomcat ${version} native binaries > =A0 =A0 =A0 =A0 > =A0 =A0 =A0 =A0 > =A0 =A0 =A0 =A0 > + =A0 =A0 =A0 =A0 > =A0 =A0 =A0 =A0 > =A0 =A0 =A0 =A0 > =A0 =A0 =A0 =A0 > @@ -2242,6 +2243,19 @@ Apache Tomcat ${version} native binaries > =A0 =A0 > =A0 > > + =A0 > + > + =A0 + =A0 =A0 =A0 =A0 =A0description=3D"Prepares the source tree to be built = in Eclipse"> > + > + =A0 =A0 > + =A0 =A0 > + =A0 =A0 > + > + =A0 =A0Eclipse project files created. > +Read the Building page on the Apache Tomcat documentation site for detai= ls on how to configure your Eclipse workplace. > + =A0 > + > =A0 > > =A0 > > Copied: tomcat/trunk/res/ide-support/eclipse/start-tomcat.launch (from r1= 001386, tomcat/trunk/Start Tomcat.launch) > URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/st= art-tomcat.launch?p2=3Dtomcat/trunk/res/ide-support/eclipse/start-tomcat.la= unch&p1=3Dtomcat/trunk/Start%20Tomcat.launch&r1=3D1001386&r2=3D1002073&rev= =3D1002073&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- tomcat/trunk/Start Tomcat.launch (original) > +++ tomcat/trunk/res/ide-support/eclipse/start-tomcat.launch Tue Sep 28 0= 9:36:08 2010 > @@ -9,5 +9,5 @@ > =A0 > =A0 > =A0 > - > + > =A0 > > Copied: tomcat/trunk/res/ide-support/eclipse/stop-tomcat.launch (from r10= 01386, tomcat/trunk/Stop Tomcat.launch) > URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/st= op-tomcat.launch?p2=3Dtomcat/trunk/res/ide-support/eclipse/stop-tomcat.laun= ch&p1=3Dtomcat/trunk/Stop%20Tomcat.launch&r1=3D1001386&r2=3D1002073&rev=3D1= 002073&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- tomcat/trunk/Stop Tomcat.launch (original) > +++ tomcat/trunk/res/ide-support/eclipse/stop-tomcat.launch Tue Sep 28 09= :36:08 2010 > @@ -9,5 +9,5 @@ > =A0 > =A0 > =A0 > - > + > =A0 > > Modified: tomcat/trunk/webapps/docs/building.xml > URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/building.xml?= rev=3D1002073&r1=3D1002072&r2=3D1002073&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- tomcat/trunk/webapps/docs/building.xml (original) > +++ tomcat/trunk/webapps/docs/building.xml Tue Sep 28 09:36:08 2010 > @@ -161,11 +161,6 @@ and the following steps have been used b > =A0

> > =A0

> -NOTE: You must complete all the above steps to fetch > -dependency libraries and build Tomcat before you can setup an Eclipse pr= oject and start > -using it. > -

> -

> =A0NOTE: This will not let you build everything under Eclipse; > =A0the build process requires use of Ant for the many stages that aren't > =A0simple Java compilations. > @@ -174,19 +169,19 @@ get warnings, reformat code, perform ref > =A0under the IDE, and so on. > =A0

> =A0

> -Complete the download of all third party dependencies required to compil= e the Tomcat > -source in Eclipse: > +Sample Eclipse project files and launch targets are provided in the > +res/ide-support/eclipse directory of the source tree. > +The instructions below will automatically copy these into the required l= ocations. > +

> +

> +An Ant target is provided as a convenience to download all binary depend= encies, and to create > +the Eclipse project and classpath files in the root of the source tree. > =A0
> =A0
> =A0 =A0 cd ${tomcat.source}
> - =A0 =A0ant extras
> + =A0 =A0ant ide-eclipse
> =A0 > =A0

> -

> -Sample Eclipse project and classpath files are provided in the root dire= ctory of the source tree. > -The sample files are named eclipse.project and eclips= e.classpath, and must > -be copied to .project and .classpath respectiv= ely before proceeding. > -

> > =A0

> =A0Start Eclipse and create a new Workspace. > @@ -212,21 +207,30 @@ and import the Tomcat project located th > =A0

> > =A0

> -You may see errors in your problems tab at this point about missing buil= d path dependencies. > -If this happens you have forgotten to execute the ant extras build to download > -these dependencies. > -

> - > -

> -Start Tomcat and Stop Tomcat launch configurat= ions are provided in the > -root directory of the source tree and will be available in the Run-&= gt;Run Configurations > -dialog. Use these to start and stop Tomcat from Eclipse. > +start-tomcat and stop-tomcat launch configurat= ions are provided in > +res/ide-support/eclipse and will be available in the Ru= n->Run Configurations > +dialog. Use these to start and stop Tomcat from Eclipse. > =A0
If you want to configure these yourself (or are using a different= IDE) > =A0then use org.apache.catalina.startup.Bootstrap as the mai= n class, > -start/stop as program arguments, and specify <= code>-Dcatalina.home=3D... > +start/stop etc. as program arguments, and spec= ify -Dcatalina.home=3D... > =A0(with the name of your build directory) as VM arguments. > =A0

> > +

> +Tweaking a few formatting preferences will make it much easier to keep c= onsistent with Tomcat > +coding conventions (and have your contributions accepted): > +

> +

> + > + =A0 > + =A0 > + =A0 > + =A0 > + =A0 > + =A0 > +
Java -> Code Style -> Formatter -> Edit...Tab policy: Spaces only
Tab and Indentation size: 4
General -> Editors -> Text EditorsDisplayed tab width: 2
Insert spaces for tabs
Show white= space characters (optional)
XML -> XML Files -> EditorIndent using spacesIndentation size: 2
Ant -> Editor -> FormatterTab size: 2
Use ta= b character instead of spaces: unchecked
> +

> + > =A0 > > =A0
> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > Did you see the patch I submitted Tim, that modified the launch files not just straight copied them? I think it was issue 50001? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org