tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <>
Subject Re: svn commit: r1002263 - /tomcat/trunk/bin/
Date Tue, 28 Sep 2010 18:18:22 GMT
On 09/28/2010 06:59 PM, wrote:
> Author: markt
> +        PID="`cat "$CATALINA_PID"`"
> +        if ps -p $PID>  /dev/null; then
> +          echo "Tomcat appears to still be running with PID $PID. Start aborted."
> +          exit 1

if $CATALINA_PID points to the file that has invalid content
the following will be shown:

ERROR: Process ID list syntax error.
********* simple selection *********  ********* selection by list *********
-A all processes                      -C by command name
-N negate selection                   -G by real group ID (supports names)
-a all w/ tty except session leaders  -U by real user ID (supports names)
-d all except session leaders         -g by session OR by effective group name
-e all processes                      -p by process ID
T  all processes on this terminal     -s processes in the sessions given
a  all w/ tty, including other users  -t by tty
g  OBSOLETE -- DO NOT USE             -u by effective user ID (supports names)
r  only running processes             U  processes for specified users
x  processes w/o controlling ttys     t  by tty
*********** output format **********  *********** long options ***********
-o,o user-defined  -f full            --Group --User --pid --cols --ppid
-j,j job control   s  signal          --group --user --sid --rows --info
-O,O preloaded -o  v  virtual memory  --cumulative --format --deselect
-l,l long          u  user-oriented   --sort --tty --forest --version
-F   extra full    X  registers       --heading --no-heading --context
                     ********* misc options *********
-V,V  show version      L  list format codes  f  ASCII art forest
-m,m,-L,-T,H  threads   S  children in sum    -y change -l format
-M,Z  security data     c  true command name  -c scheduling class
-w,w  wide output       n  numeric WCHAN,UID  -H process hierarchy

The code should actually be
ps -p $PID > /dev/null 2>&1
if [ $? -ne 0 ]; then ...

This is to be consistent with the remaining of the tests
and to not get junk from the ps output in  case of failure.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message