tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Writing unit tests
Date Mon, 20 Sep 2010 20:52:10 GMT
On 20/09/2010 13:46, Christopher Schultz wrote:

> 1. There's a method in catalina.connector.Connector called init(). When
> does that get called? I had expected that it would be called after all
> the setXXX attributes had be set on it from the digester upon start-up,
> but it appears that Connector.init /never/ gets called. That means that
> my defaults have a hard time being ... defaulted properly. I have a hack
> in there that does a sanity check when checking the list of methods to
> see if the current request should be parsed, but it seems like a waste
> of processing time during the request itself. Should I put my "startup"
> code somewhere other than Connector.init()?

That'll probably be better in 7.0.x. I do wonder what init code you
might need. I was expecting a simple boolean attribute. Once that is
sorted, we can figure out how to port it to 6.0.x

> 2. Coding conventions seem to be applied ... inconsistently. Is there a
> code style guide that I can actually follow so my code "looks right", or
> should I just look at what's already there in the files I'm modifying
> and take my best guess at what's appropriate?

Yep. Go with the current style of the file.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message