tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Can jsp-file be a JspServlet init-param?
Date Sat, 11 Sep 2010 16:57:18 GMT
On 11/09/2010 07:20, David Jencks wrote:
> 
> On Sep 8, 2010, at 11:48 PM, Mark Thomas wrote:
> 
>> On 09/09/2010 00:54, David Jencks wrote:
>>> I've recently rewritten the geronimo-jetty integration to work off the servlet
3 *Registration classes.  This works great except for servlets backed by jsp files, since
there's no way to tell the servlet container through the ServletRegistration interface that
its actually something with this extra jsp file name that needs to be added through some special
process into the request.
>>
>> That looks like an oversight in the 3.0 spec.
> 
> I'm not sure why you think that.

Because <jsp-file> is the only element of a servlet's configuration you
can't set via the registration class. I can't see any good reason for
the omission, hence my thinking it was an oversight.

>  A servlet extension mechanism such as a jsp engine can use the  servlet 3 API to add
servlets directly.  I think it would make more sense to completely remove any mention of jsp
from web.xml and the servlet spec and run jsps off a separate configuration file.

Nice idea but unlikely to happen based on past experience. The Servlet
(and JSP) EGs have bent over backwards to ensure backwards
compatibility. I can't recall any feature being removed and I doubt
something as significant as this would be removed from the Servlet spec.

> excellent, see https://issues.apache.org/bugzilla/show_bug.cgi?id=49916

I'm currently at 49884, working my way down the bug list prior to a
7.0.3 release so I'll look at this before then (unless one of the other
committers beats me to it).

> If I've understood the tomcat build this passes all the tests and also appears to cause
no tck problems in the geronimo-tomcat integration.

Sounds good.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message