tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject AprEndpoint Runnable->Thread fixes
Date Fri, 03 Sep 2010 05:38:15 GMT
Hi,

I changed the Poller, Sendfile and Acceptor classes to
extend the Thread instead just implement Runnable.

Now, that was the easy hack cause we really don't
need to extend the Thread behavior for those classes
so might no be an optimal solution.

In essence we need to wait on each of those threads
on edpoint destroy(), so we can safely call the APR
terminate ensuring those classes won't call any of the
APR methods afterwards.

If extending Thread is wrong we could add separate
Thread[] array or new interface extending Runnable
which could store the Thread instance so we do a join().

Comments?

Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message