tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49811] [PATCH] Disable UrlRewriting
Date Sat, 11 Sep 2010 17:13:23 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49811

--- Comment #10 from Mark Thomas <markt@apache.org> 2010-09-11 13:13:15 EDT ---
Functionally, the patch looks good to me and I'd propose it for Tomcat if it
wasn't for some minor cosmetic issues:
- use 4 spaces rather than tabs
- setDisableURLRewriting(boolean allow) is confusing.
setDisableURLRewriting(boolean disable) would be better

Fix those and I'll propose it for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message