Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4C59D1EE.5050300@apache.org>
Date: Wed, 04 Aug 2010 21:47:42 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB;
 rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: Again JarScanner and jarsToSkip
References: <4C595511.5070607@kippdata.de>
In-Reply-To: <4C595511.5070607@kippdata.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

On 04/08/2010 12:54, Rainer Jung wrote:
> Hello everyone,
> 
> would it make sense to make jarsToSkip publicly available in the
> JarScanner interface and default impl, in order to allow to configure it
> per context as part of context.xml?
+1

> Is there one JarScanner instance per context?
Yes.

> If so: How would we want to merge default settings and per context
> settings? Some of the default exclusions we know for sure we want to
> exclude e.g. the stuff shipped with Tomcat. Others we can't say for sure
> for all the future, like the commons stuff. So it seems if we make it
> configurable per context and do not want people to have to include the
> Tomcat stuff in every context config, the default would need to be split
> in two parts, namely the always to exclude and the default per context
> which gets overwritten.
> 
> What about allowing to match against the full path of the jar, possibly
> implicitley prefixing all pattrns which do not start with a slash with
> "**/"? Does that make sense, i.e. is there a use case? The list now
> allows glob patterns like in ant, so "**", "*" and "?". E.g. we could
> add ${catalina.home}/lib/* and ${catalina.base}/lib/* to shortcut our
> own jar list. For the classpath jars it seems the jars are all coming
> from file URLs, so retrieving the full path is easy. Concerning the
> WEB-INF/lib jars, I didn't yet check.
> 
> Should we also add standard.jar and jstl.jar to the default exclude
> list? They are scanned as part of the examples webapp. Or do we think
> the names are to generic to add them to the list?
> 
> Is there any complication, because the JarScanner is also used for
> taglib scanning? There is an API to set "noTldJar", although I'm not
> sure whether that's available by config. Default is null which leads to
> again using jarsToSkip.

I'm happy to see all of this configuration completely re-written if that
is what is required. That said, this is just a start-up optimisation.

I think we need three groups:
a) never scan (JAR or TLD)
b) default jarsToSkip
c) default noTldJar

I'd suggest all three being set in catalina.properties with b) & c)
over-ridable per context. Users can over-ride the defaults in
catalina.properties if they wish.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org