tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Standard context add parameter
Date Mon, 23 Aug 2010 11:07:47 GMT
On 23/08/2010 00:03, Wesley Acheson wrote:
> Hi, I'm trying to put together a patch as per.
> http://marc.info/?l=tomcat-user&m=128249845732568&w=2
> 
> I've put an optional value in StandardContext that I need to check in
> org.apache.catalina.connector.Response however I've left the interface
> for Context alone. (new implementations shouldn't need to implement
> the attribute).

They shouldn't but we have been fairly relaxed about adding attributes
to the Context interface - even recently - and no-one has complained. My
guess is not that many folks (if any) implement their own.

> Now I'm a bit stuck I can get the context but I'd rather not try to
> cast to StandardContext or use the typeof operator. Is it okay to add
> the parameter to standard context via addParameter? and check this via
> findParameter which is on the context interface?

I would (and have in the past) just add the attribute to the context.

> Sorry If this isn't clear.

Perfectly clear.

> Sorry if this is the wrong mailing list.

And the right place to ask. The general rule is if it involves changing
the Tomcat source code it belongs here.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message