tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
Date Fri, 20 Aug 2010 15:31:51 GMT

--- Comment #85 from Mark Thomas <> 2010-08-20 11:31:41 EDT ---
The patch is getting there but there is still quite a lot of work to do.

Starting from just a Server object the patch is insufficient. See my commits
earlier today for StandardServer and MBeanFactory. Further work is also
required. See below for details.

The patch contained a number of tabs. I'd suggest enabling validation as it
will pick this up as part of the build process.

The two new files are missing the mandatory AL2 license header.

When adding child containers, the children need to be initialized. This will
register them with the MBeanServer so they can be configured before they are
started. That should also make the startChild() method unnecessary.

I fixed most of the above and then tested with a server.xml that just had a
Server object defined. I could add everything I needed to and some bits worked
(others didn't) but I still saw a lot of errors. Overall I think you need to do
more testing and generally make things more robust.

On a related point, I noticed that the addConnector method on Service isn't
available via JMX. I suspect that this isn't an isolated issue and that other
methods exposed via MBeans will have similar issues that need to be fixed.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message