tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
Date Wed, 11 Aug 2010 16:59:33 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234

--- Comment #76 from Mark Thomas <markt@apache.org> 2010-08-11 12:59:22 EDT ---
Thanks for the updated patch.

I wasn't thinking of explicitly setting startChildren in the addChild() method
but it is a good idea and I like it. However, you need to rework your patch to
ensure startChildren is always reset, even if an Exception occurs.

Also, there is no need to manipulate startChildren in startChild() - at least I
can't see one.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message