tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
Date Sun, 01 Aug 2010 20:06:41 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234

--- Comment #68 from Mark Thomas <markt@apache.org> 2010-08-01 16:06:35 EDT ---
(In reply to comment #67)
> Any comments on this? However I am not sure this approach can be applied to
> addChild methods since different child types (Host, Context e.g.) require
> different parameters for their initialization.

Please ping sooner if you don't getting a reply in 48 hours. I missed your
23/07 post.

1. Please use 4 spaces not tabs
2. All public methods should have Javadoc comments
3. Why only modify the descriptor for StandardContext? What about Host, Engine
etc
4. re addChild. All children *must* implement Container and they all should
have a no-arg constructor. It should be simple to write a addChild method that
takes a class name. The startChldren attribute on the parent can be used to
prevent the added child from being started until it has been initialised. You
may need to change the visibility of the LifecycleMBeanBase.register() method

Overall, this looks to be heading in the right direction but I'd like to see it
get to the point where all containers can be added and removed via JMX before
it is committed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message