Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 54650 invoked from network); 28 Jul 2010 16:01:11 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Jul 2010 16:01:11 -0000 Received: (qmail 66410 invoked by uid 500); 28 Jul 2010 16:01:10 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 66338 invoked by uid 500); 28 Jul 2010 16:01:10 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 66329 invoked by uid 99); 28 Jul 2010 16:01:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 16:01:10 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.191] (HELO smtp6.freeserve.com) (193.252.22.191) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 16:01:02 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3606.me.freeserve.com (SMTP Server) with ESMTP id CC95B7000086 for ; Wed, 28 Jul 2010 18:00:40 +0200 (CEST) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3606.me.freeserve.com (SMTP Server) with ESMTP id BE7DF700008B for ; Wed, 28 Jul 2010 18:00:40 +0200 (CEST) Received: from mail.homeinbox.net (unknown [91.109.171.240]) by mwinf3606.me.freeserve.com (SMTP Server) with ESMTP id 981517000086 for ; Wed, 28 Jul 2010 18:00:40 +0200 (CEST) X-ME-UUID: 20100728160040623.981517000086@mwinf3606.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by mail.homeinbox.net (Postfix) with ESMTP id BF33032F0B for ; Wed, 28 Jul 2010 17:00:54 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from mail.homeinbox.net ([127.0.0.1]) by localhost (mail.homeinbox.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VVXjM8Vbj2tP for ; Wed, 28 Jul 2010 17:00:51 +0100 (BST) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.homeinbox.net (Postfix) with ESMTPSA id C7B1E32F07 for ; Wed, 28 Jul 2010 17:00:51 +0100 (BST) Message-ID: <4C50541B.3070109@apache.org> Date: Wed, 28 Jul 2010 17:00:27 +0100 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r966882 - in /tomcat/trunk: build.properties.default build.xml checkstyle.xml webapps/docs/changelog.xml References: <20100722223130.A183D23889E0@eris.apache.org> In-Reply-To: X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/07/2010 03:38, Bill Barker wrote: > This is probably cruelty against dead horses, but shouldn't the > download target be conditional as well? Since checkstyle is LGPL > licensed, I really don't think that we should be installing it by > default for anyone that wants to build Tomcat. That works for me. > Being an extremist on > this issue, I would actually prefer that we remove the download-validate > target. This would mean that anyone that wants to use it has to have > installed it already, and so have accepted the LGPL license. I for one, > expect that when I download an Apache product, that it will only install > compatibly licensed software. At least not without warning me otherwise. > > This is a -0: vent. There is nothing wrong from a licensing stand point > on how we are using it. I added a comment in build.properties just above the option you need to override to enable validation. Hopefully that is a reasonable compromise. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org