Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 19740 invoked from network); 2 Jul 2010 17:59:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Jul 2010 17:59:49 -0000 Received: (qmail 88784 invoked by uid 500); 2 Jul 2010 17:59:48 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 88726 invoked by uid 500); 2 Jul 2010 17:59:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 88717 invoked by uid 99); 2 Jul 2010 17:59:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jul 2010 17:59:47 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of pid@pidster.com designates 74.125.82.43 as permitted sender) Received: from [74.125.82.43] (HELO mail-ww0-f43.google.com) (74.125.82.43) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jul 2010 17:59:38 +0000 Received: by wwb39 with SMTP id 39so1395115wwb.0 for ; Fri, 02 Jul 2010 10:58:17 -0700 (PDT) Received: by 10.227.137.15 with SMTP id u15mr636292wbt.86.1278093497170; Fri, 02 Jul 2010 10:58:17 -0700 (PDT) Received: from Phoenix.local (cpc2-lewi13-2-0-cust269.2-4.cable.virginmedia.com [86.14.119.14]) by mx.google.com with ESMTPS id p29sm6381343wbc.7.2010.07.02.10.58.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Jul 2010 10:58:16 -0700 (PDT) Message-ID: <4C2E28B6.7040402@pidster.com> Date: Fri, 02 Jul 2010 18:58:14 +0100 From: Pid Reply-To: pid@pidster.com Organization: Pidster Inc User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r960069 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java References: <20100702175056.E5C0523888D2@eris.apache.org> <4C2E282D.7040300@pidster.com> In-Reply-To: <4C2E282D.7040300@pidster.com> X-Enigmail-Version: 1.1.1 OpenPGP: id=62590808 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig2F4640E4E351FD805FD8B6F8" X-Virus-Checked: Checked by ClamAV on apache.org --------------enig2F4640E4E351FD805FD8B6F8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/07/2010 18:55, Pid wrote: > On 02/07/2010 18:50, markt@apache.org wrote: >> Author: markt >> Date: Fri Jul 2 17:50:56 2010 >> New Revision: 960069 >> >> URL: http://svn.apache.org/viewvc?rev=3D960069&view=3Drev >> Log: >> Make new timeout thread a daemon thread so Tomcat will shutdown proper= ly >> >> Modified: >> tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java >> >> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.jav= a >> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/= util/net/JIoEndpoint.java?rev=3D960069&r1=3D960068&r2=3D960069&view=3Ddif= f >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (ori= ginal) >> +++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Fri = Jul 2 17:50:56 2010 >> @@ -401,7 +401,8 @@ public class JIoEndpoint extends Abstrac >> } >> =20 >> // Start async timeout thread >> - Thread timeoutThread =3D new Thread(new AsyncTimeout(), g= etName() + "-AsyncTimeout"); >> + Thread timeoutThread =3D new Thread(new AsyncTimeout(),ge= tName() + "-AsyncTimeout"); >=20 > Is that a comma? ...out(),getNam... Answer: yes. And it's deliberate. Please ignore my overheating brain. p > p >=20 >> + timeoutThread.setDaemon(true); >> timeoutThread.start(); >> } >> } >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org >> For additional commands, e-mail: dev-help@tomcat.apache.org >> >=20 >=20 --------------enig2F4640E4E351FD805FD8B6F8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.14 (Darwin) iQIcBAEBCgAGBQJMLii2AAoJEGoM2OGpOvr9UucP/1+jziQapuXdb9IyrDSJvMD0 BxIE38AD7LhNxwSYySdHf+l8t24HNAgH6EPEm+WoX8iHcqVPLwzxhhUx4+F0PWgp WVLSDEbUlvlz0IFTrXNAsmmbEkxeYIreAirLijpy57wrgmkcuVLxBs1u02TLXx2E c3CUctkVvmXh3maPPbadh0XwP8g51GxxFIMI37K09Y5c2jpa5zL3mDV7eN527C/Q 7kbDaGY2qvU5vdM2+aW65ouh6k15/bOlv3mBez9V9aqGkmw8EfyymOs0oFlh5ssD NH7WB+1lESQsK1dHuPFtstGa6M01eJIm41H75FaKtn4KPPM9k2c2C4Bv4Q4RpPhJ idYn/7aV/x7ltpk4w+Z/90XrnANyaAp1NI7m5mQz9Q3ju9ARDOIrB9f6EAbdhUB1 K/y7Lg0hnAgVKd7rHlva2/4ubuXwpMSrxKfRSwK9qomPh3vnkQLMBsN/qpDXNYr5 +JWnHg7M3uUNz09GIRmEWMpLl19MIA61gPWdk+p7q2EMqBHiOuI4LhL6R/0uKFJj yVtIs+Hk2qOtTosbISPJLezEfCJj+9CwW5a8tbHm75gPn5kzePKDZbUKPEPvkdTH ZtPv/hY+uG4zKpTdZOhT3hhpGVX87Uu99GEGtGyehZamMmbiF8jkDsDZYD3YzsWG 5L4dF94hwU2b2+WzCHYj =JzwU -----END PGP SIGNATURE----- --------------enig2F4640E4E351FD805FD8B6F8--