tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <flame...@gmail.com>
Subject Re: [taglibs] Questions in ForEachSupport
Date Thu, 01 Jul 2010 06:02:57 GMT
On Tue, Jun 29, 2010 at 11:45 PM, Jeremy Boynes <jboynes@apache.org> wrote:
> In bug 45197 https://issues.apache.org/bugzilla/show_bug.cgi?id=45197 Henri wrote:
> * Look at questions in the length method in ForEachSupport.java
> * Look at commented out code in prepre in ForEachSupport.java
>
> By "in the length method" did you mean line #241 where the length gets set to 0? That's
> different to the non-deferred case which throws an exception on line #402. I'd suggest
we do
> the same for both (throwing the exception).

That was the one. And agreed - throwing a JspTagException makes sense.

> The commented code in prepare that sets the itemsName EL variable is redundant as that
is
> also done in LoopTagSupport line #532 (assuming the Apache implementation of the JSTL
> API). Looks like this can just be deleted.

Looks good; and that would have been the commented code in question.
The commented out ResultSet code below is also presumably just chaff,
but it was the variable setting that was newly introduced.

> if that sounds good, I'll contribute a patch for those changes.

Many thanks :)

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message