tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r964219 [1/2] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/ webapps/docs/config/
Date Wed, 28 Jul 2010 16:14:07 GMT
On 27/07/2010 14:16, Remy Maucherat wrote:
> On Wed, 2010-07-14 at 22:11 +0000, markt@apache.org wrote:
>> Author: markt
>> Date: Wed Jul 14 22:11:30 2010
>> New Revision: 964219
>>
>> URL: http://svn.apache.org/viewvc?rev=964219&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
>> Add the ExpiresFilter, a port of mod_expires
>> Patch provided by Cyrille Le Clerc
> 
> Isn't the amount of logging high in this filter ? Esp in
> getExpirationDate. I didn't try to run it, simply browsing through the
> code.

Agreed. Those error level messages should be debug in that method. The
rest of the class looks OK. I'll fix that in a sec...

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message