tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: Proposal: Some todo's at AsyncContext detected...
Date Mon, 05 Jul 2010 06:48:49 GMT
On 04.07.2010 22:11, Peter Ro├čbach wrote:
> Hmm,
>
> Spec says:
>
> public boolean isAsyncStarted() - Returns true if async processing
> has started on this request, and false otherwise. If this request has been
> dispatched using one of the AsyncContext.dispatch methods since it was
> put in asynchronous mode, or a call to AsynContext.complete is made, this
> method returns false.
>
> ===
> But the example with Bug 49528 don't call directly dispatch, it calls
> AsyncContext.start().
> At Tomcat we start doesn't start a Container Thread. We internally call
> a doInternalDispatch at StandardWrapperValve
> with the callee thread.
> ...
> } else {
> if (request.isAsyncDispatching()) {
> //TODO SERVLET3 - async
> ((AsyncContextImpl)request.getAsyncContext()).doInternalDispatch();
> ...
>
> I revert the fix, and correct the testcase.

I wasn't commenting a specific BZ issue or your test case. I was 
commenting the TCK failure JFC noticed. It simply checks the cited 
requirement on isAsyncStarted() and fails after your change that starts 
the AsyncTimeout thread. Without your change it works.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message