tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 49268] Use checkstyle to enforce common code style
Date Mon, 12 Jul 2010 05:18:08 GMT

--- Comment #3 from Marc Guillemot <> 2010-07-12 01:18:01 EDT ---
(In reply to comment #2)
> ...
> 1) Checkstyle version should not be hard-coded in build.xml.

what is your preferred way? I wanted to avoid having an additional property but
I can change it.

> > style="${checkstyle.home}/checkstyle-5.1/contrib/checkstyle-noframes.xsl"/> 
> 2) What is the origin of the res/checkstyle.xml file? There is no copyright or
> license notice there.

this is the default checkstyle config file... with nearly everything as

> 3) Contrary to the written "- activates only check for tabs", there are more
> checks that are enabled in the proposed checkstyle file.

this is correct. The very few remaining checkers were the default one that
weren't failing (what means that the style of some sources can be even worse
than here ;-)).

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message