tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49268] Use checkstyle to enforce common code style
Date Sun, 11 Jul 2010 00:23:06 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268

--- Comment #2 from Konstantin Kolinko <knst.kolinko@gmail.com> 2010-07-10 20:23:02
EDT ---
Thank you for the effort.
I won't comment on the project policies - that is to be discussed and decided
on dev@.

Several comments on the patch itself:

1) Checkstyle version should not be hard-coded in build.xml.

> style="${checkstyle.home}/checkstyle-5.1/contrib/checkstyle-noframes.xsl"/> 

2) What is the origin of the res/checkstyle.xml file? There is no copyright or
license notice there.

3) Contrary to the written "- activates only check for tabs", there are more
checks that are enabled in the proposed checkstyle file.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message