Return-Path: 
 <dev-return-106677-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org>
Delivered-To: apmail-tomcat-dev-archive@www.apache.org
Received: (qmail 53019 invoked from network); 3 Jun 2010 13:50:36 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 3 Jun 2010 13:50:36 -0000
Received: (qmail 99198 invoked by uid 500); 3 Jun 2010 13:50:36 -0000
Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org
Received: (qmail 99119 invoked by uid 500); 3 Jun 2010 13:50:36 -0000
Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@tomcat.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@tomcat.apache.org>
List-Post: <mailto:dev@tomcat.apache.org>
List-Id: <dev.tomcat.apache.org>
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Delivered-To: mailing list dev@tomcat.apache.org
Received: (qmail 99109 invoked by uid 99); 3 Jun 2010 13:50:36 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 13:50:35 +0000
X-ASF-Spam-Status: No, hits=-2.3 required=10.0
	tests=RCVD_IN_DNSWL_MED,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of rainer.jung@kippdata.de
 designates 195.227.30.149 as permitted sender)
Received: from [195.227.30.149] (HELO mailserver.kippdata.de) (195.227.30.149)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 13:50:28 +0000
Received: from [192.168.2.104] ([192.168.2.104])
	by mailserver.kippdata.de (8.13.5/8.13.5) with ESMTP id o53Do6EI028552
	for <dev@tomcat.apache.org>; Thu, 3 Jun 2010 15:50:07 +0200 (CEST)
Message-ID: <4C07B30E.8020906@kippdata.de>
Date: Thu, 03 Jun 2010 15:50:06 +0200
From: Rainer Jung <rainer.jung@kippdata.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de;
 rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r950983 - /tomcat/trunk/conf/server.xml
References: <20100603131627.74B06238890B@eris.apache.org>
In-Reply-To: <20100603131627.74B06238890B@eris.apache.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

On 03.06.2010 15:16, markt@apache.org wrote:
> Author: markt
> Date: Thu Jun  3 13:16:27 2010
> New Revision: 950983
>
> URL: http://svn.apache.org/viewvc?rev=950983&view=rev
> Log:
> Enable access logs by default for 7.0.x
>
> Modified:
>      tomcat/trunk/conf/server.xml
>
> Modified: tomcat/trunk/conf/server.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/server.xml?rev=950983&r1=950982&r2=950983&view=diff
> ==============================================================================
> --- tomcat/trunk/conf/server.xml (original)
> +++ tomcat/trunk/conf/server.xml Thu Jun  3 13:16:27 2010
> @@ -127,10 +127,8 @@
>
>           <!-- Access log processes all example.
>                Documentation at: /docs/config/valve.html -->
> -<!--
>           <Valve className="org.apache.catalina.valves.AccessLogValve" directory="logs"
>                  prefix="localhost_access_log." suffix=".txt" pattern="common" resolveHosts="false"/>
> -        -->
>
>         </Host>
>       </Engine>

+1000

Another related observation: Users often are not aware that they can 
substitute "common" with an individual log pattern, although that is 
very often essential (like including %D etc.). Even though many know 
similar constructs from Apache httpd, it's not obvious for them that 
they can substitute the word "common" with a pattern.

Should we add an example pattern to server.xml? Or would it be easier 
understandable if we removed the abbreviation "common" from the default 
config and replace it with the full pattern?

There's also the topic that the common pattern contains quotation marks, 
which you can't add verbatim to the attribute if you want to extend the 
common pattern with additional items. So adding an example or using the 
real pattern in the default configuration would show users how to work 
around that (&quot; or similar).

My .1 Euro Cents.

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org