Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 92315 invoked from network); 27 Jun 2010 22:23:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 27 Jun 2010 22:23:36 -0000 Received: (qmail 92688 invoked by uid 500); 27 Jun 2010 22:23:35 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 92593 invoked by uid 500); 27 Jun 2010 22:23:34 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 92582 invoked by uid 99); 27 Jun 2010 22:23:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jun 2010 22:23:34 +0000 X-ASF-Spam-Status: No, hits=2.9 required=10.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [74.125.83.173] (HELO mail-pv0-f173.google.com) (74.125.83.173) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jun 2010 22:23:25 +0000 Received: by pvg12 with SMTP id 12so5571717pvg.18 for ; Sun, 27 Jun 2010 15:22:04 -0700 (PDT) Received: by 10.142.117.5 with SMTP id p5mr4417474wfc.23.1277677323968; Sun, 27 Jun 2010 15:22:03 -0700 (PDT) Received: from [10.0.1.31] (c-24-16-66-36.hsd1.wa.comcast.net [24.16.66.36]) by mx.google.com with ESMTPS id c15sm3022441rvi.11.2010.06.27.15.22.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 27 Jun 2010 15:22:03 -0700 (PDT) Sender: Jeremy Boynes Subject: [taglibs] Thread safety in FormatDateSupport From: Jeremy Boynes Content-Type: multipart/alternative; boundary=Apple-Mail-11-869895139 Message-Id: <240577A6-4158-4DE4-9ECB-2FB9972FF9A2@apache.org> Date: Sun, 27 Jun 2010 15:22:02 -0700 To: dev@tomcat.apache.org Mime-Version: 1.0 (Apple Message framework v1081) X-Mailer: Apple Mail (2.1081) X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-11-869895139 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I was looking at a patch for FormatDateSupport [1] to remove its = dependency on a copy of LRUMap taken from Commons and have a question on = the thread safety involved as, although the cache is synchronized, the = formatters it contains are used outside that block. This was discussed in bug 32311 [2] but the synchronization code = suggested there wasn't added. Am I missing something, or should I reopen = 32311 and add a patch? -- Jeremy [1] = http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl/src/mai= n/java/org/apache/taglibs/standard/tag/common/fmt/FormatDateSupport.java [2] https://issues.apache.org/bugzilla/show_bug.cgi?id=3D32311#c4= --Apple-Mail-11-869895139--