tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremy Boynes <jboy...@apache.org>
Subject [taglibs] Questions in ForEachSupport
Date Wed, 30 Jun 2010 06:45:15 GMT
In bug 45197 https://issues.apache.org/bugzilla/show_bug.cgi?id=45197 Henri wrote:
* Look at questions in the length method in ForEachSupport.java
* Look at commented out code in prepre in ForEachSupport.java

By "in the length method" did you mean line #241 where the length gets set to 0? That's different
to the non-deferred case which throws an exception on line #402. I'd suggest we do the same
for both (throwing the exception).

The commented code in prepare that sets the itemsName EL variable is redundant as that is
also done in LoopTagSupport line #532 (assuming the Apache implementation of the JSTL API).
Looks like this can just be deleted.

if that sounds good, I'll contribute a patch for those changes.
Cheers
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message