tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r950587 - in /tomcat/trunk: java/org/apache/catalina/AccessLog.java java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/config/valve.xml
Date Wed, 02 Jun 2010 16:25:50 GMT
On 02/06/2010 16:40, Tim Funk wrote:
> Cool - One (very minor) nit ... A safer size might be 500.
> A typical User agent string by itself is 100+ characters which will
> easily take the log line over 128 characters.
> 
> StringBuilder result = new StringBuilder(128);

User agent isn't logged by default so I think 128 is probably OK.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message