tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49505] ApplicationHttpRequest.setAttribute doesn't call the wrapper's setAttribute in case of "special" attributes
Date Mon, 28 Jun 2010 02:48:45 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49505

ranjix@hotmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |FIXED

--- Comment #2 from ranjix@hotmail.com 2010-06-27 22:48:41 EDT ---
Thanks Mark, several issues. 

1. considering Tomcat is open-source and so, do you think it would be a big
problem if I replace the code 
        if (!setSpecial(name, value)) {
            getRequest().setAttribute(name, value);
        }
with 
        setSpecial(name, value)); 
        getRequest().setAttribute(name, value);
?
In my tests, my code seems to work fine with the modified version, is just that
I might not realize all the implications of doing this. 


2. talking about specification. It's true that the spec doesn't state clearly
that the attributes must be set using the wrapper's setAttribute, but one must
wonder why that kind of overriding would be allowed, if not to be used by the
container. In this particular case, the choice looks somewhat random (call
setAttributes only on some attributes, but not on all), and is obviously
limiting for the user. 

appreciate your help, 
Ranjix

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message