Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 32043 invoked from network); 17 May 2010 17:51:28 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 May 2010 17:51:28 -0000 Received: (qmail 15446 invoked by uid 500); 17 May 2010 17:51:27 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 15365 invoked by uid 500); 17 May 2010 17:51:27 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 15356 invoked by uid 99); 17 May 2010 17:51:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 May 2010 17:51:27 +0000 X-ASF-Spam-Status: No, hits=-0.6 required=10.0 tests=AWL,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com designates 209.85.219.213 as permitted sender) Received: from [209.85.219.213] (HELO mail-ew0-f213.google.com) (209.85.219.213) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 May 2010 17:51:21 +0000 Received: by ewy5 with SMTP id 5so1438164ewy.0 for ; Mon, 17 May 2010 10:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=kpyZW0cNeW+SZSE/fgNtDGixeWDb8Wt4LT6bE3fscqE=; b=gV8JY10ZU6kJQ8INEznLj+nsF4ZV+1LU/ZTgDedKaRqZ9EUvm8qYZJg6uI0TzvXE9k wp8WpAMQaD15f05fZUnzushPJCuQUpLEJtP5NceNGFypZk5PSH7pmESr+1RSaARLLHA7 ZtBLj6UHyU+QglSXVvIZ0xgbL8mpvaRowooxg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=hUzPTrds9qKLnVgfCw+UmkTH5m414Ev7268HYzLdo9PQTyfshoaDjOW5Eyg76PNhIU yQVFbe3W+3AJ9mT2/ovk2gFkyL8XxAbGSnslgG2OF3wY/PfXkKv/JP/mz06eHlNUYnOZ dBlmfmv7yAtK2ZV/kKjlFbosH8W2p4oyTYVew= MIME-Version: 1.0 Received: by 10.103.3.20 with SMTP id f20mr3734510mui.95.1274118659966; Mon, 17 May 2010 10:50:59 -0700 (PDT) Received: by 10.102.83.2 with HTTP; Mon, 17 May 2010 10:50:59 -0700 (PDT) In-Reply-To: <20100517174553.BB5932388A02@eris.apache.org> References: <20100517174553.BB5932388A02@eris.apache.org> Date: Mon, 17 May 2010 21:50:59 +0400 Message-ID: Subject: Re: svn commit: r945271 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamFilter.java DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java From: Konstantin Kolinko To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2010/5/17 : > Author: markt > Date: Mon May 17 17:45:53 2010 > New Revision: 945271 > > URL: http://svn.apache.org/viewvc?rev=3D945271&view=3Drev > Log: > Fix Eclipse warnings. > Reduce line length. > > @@ -243,14 +253,9 @@ public class TestContextConfigAnnotation > =A0 =A0 =A0 =A0 =A0 =A0 if (eclipseFile.exists()) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (antFile.lastModified() >=3D eclipseFi= le.lastModified()) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return antFile; > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} else { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return eclipseFile; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } > - =A0 =A0 =A0 =A0 =A0 =A0} else { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return antFile; > =A0 =A0 =A0 =A0 =A0 =A0 } > - =A0 =A0 =A0 =A0} else { > - =A0 =A0 =A0 =A0 =A0 =A0return eclipseFile; > =A0 =A0 =A0 =A0 } > + =A0 =A0 =A0 =A0return eclipseFile; > =A0 =A0 } > =A0} Was: return antFile; Now: return eclipseFile; BTW: What are those Eclipse warnings, that discourage use of 'else' branche= s? http://svn.apache.org/viewvc?rev=3D945265&view=3Drev Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org