Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 54308 invoked from network); 1 May 2010 15:31:48 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 1 May 2010 15:31:48 -0000 Received: (qmail 14059 invoked by uid 500); 1 May 2010 15:31:47 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 13996 invoked by uid 500); 1 May 2010 15:31:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 13987 invoked by uid 99); 1 May 2010 15:31:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 May 2010 15:31:47 +0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=AWL,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.159] (HELO smtp5.freeserve.com) (193.252.22.159) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 May 2010 15:31:39 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3433.me.freeserve.com (SMTP Server) with ESMTP id 211AF7000D7C for ; Sat, 1 May 2010 17:31:18 +0200 (CEST) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3433.me.freeserve.com (SMTP Server) with ESMTP id 13F9F7000D7D for ; Sat, 1 May 2010 17:31:18 +0200 (CEST) Received: from mail.homeinbox.net (unknown [91.109.175.104]) by mwinf3433.me.freeserve.com (SMTP Server) with ESMTP id E5FBF7000D7C for ; Sat, 1 May 2010 17:31:17 +0200 (CEST) X-ME-UUID: 20100501153117942.E5FBF7000D7C@mwinf3433.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by mail.homeinbox.net (Postfix) with ESMTP id E834F329F9 for ; Sat, 1 May 2010 16:31:48 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from mail.homeinbox.net ([127.0.0.1]) by localhost (mail.homeinbox.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Y-q4S0U8QIa for ; Sat, 1 May 2010 16:31:45 +0100 (BST) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.homeinbox.net (Postfix) with ESMTPSA id 3389A329F1 for ; Sat, 1 May 2010 16:31:45 +0100 (BST) Message-ID: <4BDC493D.9040500@apache.org> Date: Sat, 01 May 2010 16:31:09 +0100 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties References: <20100501142651.35B7523889B9@eris.apache.org> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 01/05/2010 16:15, Konstantin Kolinko wrote: > 2010/5/1 : >> Author: markt >> Date: Sat May 1 14:26:50 2010 >> New Revision: 940038 >> >> URL: http://svn.apache.org/viewvc?rev=940038&view=rev >> Log: >> Minor clean-up having reviewed the diff between current code and the code prior to the Lifecycle re-factoring >> > >> @@ -780,11 +780,7 @@ public class Catalina { >> public void run() { >> >> if (getServer() != null) { >> - try { >> - Catalina.this.stop(); >> - } catch (Exception e) { >> - log.error(sm.getString("catalina.shutdownHookFail"), e); >> - } >> + Catalina.this.stop(); >> } >> > > Why are you removing the above try/catch? It was added to catch LifecycleException when I made Catalina implement Lifecycle. When I removed that interface, I changed this to Exception but I could have / should have just removed it. So I did. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org