tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 49268] New: Use checkstyle to enforce common code style
Date Mon, 10 May 2010 16:12:36 GMT

           Summary: Use checkstyle to enforce common code style
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina

Created an attachment (id=25423)
 --> (
Patch adding target checkstyle to main build.xml with a extrem minimal number
of checks

Tomcat code style is not consistent but it should be (it would give more time
to discuss about unit tests rather than about code style).

Rather than to propose a huge patch in one time, I propose a simple one that:
- adds a checkstyle target to the build.xml
- adds a chestyle.xml configuration file (the "sun coding conventions") with
nearly everything deactivated (otherwise it gives over 80000 style errors)
- activates only check for tabs

With this check the checkstyle target fails as a lot of files still contain a
tab character. A find / replace by a committer makes far more sense than
providing it in the patch as it would be more difficult to review.

Of course it would make sense to add this target to the default build.

Once this patch has been applied, work can start on other checkers, like the
one verifying the presence of Version Javdoc tag in the right format.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message