tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r945231 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
Date Mon, 17 May 2010 17:27:33 GMT
2010/5/17 Mark Thomas <markt@apache.org>:
> On 17/05/2010 18:08, Mark Thomas wrote:
>> On 17/05/2010 17:50, Konstantin Kolinko wrote:
>>> I am a bit shivering looking at ([a++] != [b++]),
>>> but I did minimal changes to fix the issue.
>>
>> Understood. If I get a chance, I'll look to see if I can find an equally
>> good alternative.
>
> How about (diff to original file)
>

It fails for a reason. There should be if (srcLen == 1).

BTW, my patch removes if( srcPos==srcEnd ) check inside the loop,
so it may run a bit faster. :]  Though that would be hard to measure.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message