tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r945271 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamFilter.java DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java
Date Mon, 17 May 2010 17:50:59 GMT
2010/5/17  <markt@apache.org>:
> Author: markt
> Date: Mon May 17 17:45:53 2010
> New Revision: 945271
>
> URL: http://svn.apache.org/viewvc?rev=945271&view=rev
> Log:
> Fix Eclipse warnings.
> Reduce line length.
>


> @@ -243,14 +253,9 @@ public class TestContextConfigAnnotation
>             if (eclipseFile.exists()) {
>                 if (antFile.lastModified() >= eclipseFile.lastModified())
{
>                     return antFile;
> -                } else {
> -                    return eclipseFile;
>                 }
> -            } else {
> -                return antFile;
>             }
> -        } else {
> -            return eclipseFile;
>         }
> +        return eclipseFile;
>     }
>  }

Was: return antFile;
Now: return eclipseFile;

BTW: What are those Eclipse warnings, that discourage use of 'else' branches?
http://svn.apache.org/viewvc?rev=945265&view=rev

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message