tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
Date Mon, 17 May 2010 09:47:45 GMT
2010/5/17 Mark Thomas <markt@apache.org>:
> On 17/05/2010 09:49, Konstantin Kolinko wrote:
>> findChar() was the "correct" implementation.
>> It is indexOf() that is 0-127.
>
> We could fix that but given the current usage, I am happy with just
> supporting 0-127.
>

I am happy with the old code:
- indexOf() supporting 0-127,
 as it is only used to search for chars like '%', '=', '&' which are
0-127, --- I agree with you.
- I think findChar() should still support 0-255 as it did.

That means reverting r945016.




Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message