tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r945231 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
Date Mon, 17 May 2010 17:08:33 GMT
On 17/05/2010 17:50, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas <markt@apache.org>:
>>
>> That's pretty ugly. Is there really no other way?
>>
> 
> You mean, the named loop is ugly?
> 
> Or the old code?

It was the named loop.

> I am a bit shivering looking at ([a++] != [b++]),
> but I did minimal changes to fix the issue.

Understood. If I get a chance, I'll look to see if I can find an equally
good alternative.

> The code runs frequently, so I think/hope that somebody
> has tried to optimize it for performance.

It certainly looks like it.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message