tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties
Date Sat, 01 May 2010 15:31:09 GMT
On 01/05/2010 16:15, Konstantin Kolinko wrote:
> 2010/5/1  <markt@apache.org>:
>> Author: markt
>> Date: Sat May  1 14:26:50 2010
>> New Revision: 940038
>>
>> URL: http://svn.apache.org/viewvc?rev=940038&view=rev
>> Log:
>> Minor clean-up having reviewed the diff between current code and the code prior to
the Lifecycle re-factoring
>>
> 
>> @@ -780,11 +780,7 @@ public class Catalina {
>>         public void run() {
>>
>>             if (getServer() != null) {
>> -                try {
>> -                    Catalina.this.stop();
>> -                } catch (Exception e) {
>> -                    log.error(sm.getString("catalina.shutdownHookFail"), e);
>> -                }
>> +                Catalina.this.stop();
>>             }
>>
> 
> Why are you removing the above try/catch?

It was added to catch LifecycleException when I made Catalina implement
Lifecycle. When I removed that interface, I changed this to Exception
but I could have / should have just removed it. So I did.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message