tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r941500 - /tomcat/tc5.5.x/trunk/STATUS.txt
Date Wed, 05 May 2010 21:25:38 GMT
Author: markt
Date: Wed May  5 21:25:37 2010
New Revision: 941500

URL: http://svn.apache.org/viewvc?rev=941500&view=rev
Log:
Withdraw broken patch, vote for Konstantin's

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=941500&r1=941499&r2=941500&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Wed May  5 21:25:37 2010
@@ -47,23 +47,10 @@ PATCHES PROPOSED TO BACKPORT:
   Make sure first response post deletion is correct
   Port of r439565, r832102 & r904834
   http://people.apache.org/~markt/patches/2010-01-30-bug47878-tc5.patch
-  +1: markt
-  -1: kkolinko: (I think the patch to JspServletWrapper#service() method is wrong.
-
-     One thing that surely is wrong there: when FileNotFoundException is caught after
-     compile() we may respond with response.sendError(SC_NOT_FOUND).
-     This sendError() call should be followed by return, but instead we
-     fall down to execute theServlet.service() method.
-     Actually that sendError() is not needed, as we can just rethrow the FNFE:
-     our caller - JspServlet#serviceJspFile() - will catch it and report.
-
-     I propose a corrected patch below. I replaced the proposed changes to
-     JspServletWrapper#service() with the current code from 6.0.x.
-     )
-
+  (Above patch is wrong - it is missing at least r562752, maybe others)
   Corrected patch based on Mark's one:
   http://people.apache.org/~kkolinko/patches/2010-04-22_tc55_bug47878.patch
-  +1: kkolinko
+  +1: kkolinko, markt
   -1:
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message