tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49218] Fix support for META-INF/resources
Date Mon, 03 May 2010 09:48:44 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49218

--- Comment #6 from Peter Rossbach <pr@objektpark.de> 2010-05-03 05:48:36 EDT ---

(In reply to comment #5)
> (In reply to comment #4)
> TestStandardContextResources calling resourceF.jsp in r939650 checks for wrong
> value. It should look for "resourceF.jsp in resources.jar".
Fix with 940405. Sorry!

> 
> Besides that, it really uncovered a bug. The test fails because of the
> following:
> 
> 5. In BaseDirContext#lookup():
> altDirContext.lookup("META-INF/resources/" + name) does not return null, but
> throws a NamingException, which aborts the for( : altDirContexts) cycle.
Ok, look at listBindings. We can ignore the sub Exceptions.
Fixed!

> 
> So, either lookup for resourceF.jsp or for resourceF.jsp will fail, depending
> on the order in altDirContexts (the spec says that the order is arbitrary).
> 
> 
> 6. Also in BaseDirContext#lookup():
> doLookup(name) call is also documented to throw NamingException.
> Either it does not throw it and the doLookup method signature has to be updated
> (or at least add a JavaDoc there), or the code is broken.
+1 .. Go ahead to fix doLookup(name)!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message