Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 94956 invoked from network); 29 Apr 2010 06:39:58 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 29 Apr 2010 06:39:58 -0000 Received: (qmail 75681 invoked by uid 500); 29 Apr 2010 06:39:58 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 75563 invoked by uid 500); 29 Apr 2010 06:39:57 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 75554 invoked by uid 99); 29 Apr 2010 06:39:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Apr 2010 06:39:57 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [83.169.24.34] (HELO vwp4042.webpack.hosteurope.de) (83.169.24.34) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Apr 2010 06:39:48 +0000 Received: from dslb-092-072-218-099.pools.arcor-ip.net ([92.72.218.99] helo=[192.168.2.113]); authenticated by vwp4042.webpack.hosteurope.de running ExIM with esmtpsa (TLSv1:RC4-SHA:128) id 1O7NPE-0001OP-Mf; Thu, 29 Apr 2010 08:39:28 +0200 Message-Id: <297DC6C5-D943-4518-9D75-652EC8EC7460@objektpark.de> From: =?ISO-8859-1?Q?Peter_Ro=DFbach?= To: "Tomcat Developers List" In-Reply-To: <4BD8C02D.3090707@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: svn commit: r937325 - in /tomcat/trunk/java/org/apache: catalina/ha/session/DeltaManager.java el/lang/ExpressionBuilder.java Date: Thu, 29 Apr 2010 08:39:28 +0200 References: <20100423150958.6FCCB23889B6@eris.apache.org> <4BD56E57.7010202@apache.org> <8594A4A8-D4DB-4890-BA8F-39ABC9D7B7F7@objektpark.de> <4BD8C02D.3090707@apache.org> X-Mailer: Apple Mail (2.936) X-bounce-key: webpack.hosteurope.de;pr@objektpark.de;1272523188;6cd44f77; X-Virus-Checked: Checked by ClamAV on apache.org Add to my ToDo list :-) Peter Am 29.04.2010 um 01:09 schrieb Mark Thomas: >> .. >> >> and also we can optimized the "for"-statement to >> for(Valve valve: valves) { >> if(valve instanceof ReplicationValve) { >> replicationValve = (ReplicationValve)valve ; >> break; >> } >> } > > Not without changing when the debug message gets logged. Not sure we > want to do that. I'll leave further optimisations of this but to you > since you know the code better than I do. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org