Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 369 invoked from network); 13 Apr 2010 11:33:20 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Apr 2010 11:33:20 -0000 Received: (qmail 50939 invoked by uid 500); 13 Apr 2010 11:33:19 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 50794 invoked by uid 500); 13 Apr 2010 11:33:18 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 50785 invoked by uid 99); 13 Apr 2010 11:33:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Apr 2010 11:33:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Apr 2010 11:33:15 +0000 Received: from thor.apache.org (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3DBWrMa009371 for ; Tue, 13 Apr 2010 07:32:53 -0400 (EDT) Received: (from daemon@localhost) by thor.apache.org (8.13.8+Sun/8.13.8/Submit) id o3DBWrhm009370; Tue, 13 Apr 2010 07:32:53 -0400 (EDT) Date: Tue, 13 Apr 2010 07:32:53 -0400 (EDT) Message-Id: <201004131132.o3DBWrhm009370@thor.apache.org> From: bugzilla@apache.org To: dev@tomcat.apache.org Subject: DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 7 X-Bugzilla-Component: Catalina X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: chamibuddhika@gmail.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@tomcat.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Attachment #25228 is obsolete In-Reply-To: References: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 chamith buddhika changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25228|0 |1 is obsolete| | --- Comment #7 from chamith buddhika 2010-04-13 07:32:51 EDT --- Created an attachment (id=25277) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25277) Adding createStandardService method to MBeanFactory Sorry for the delay. I was busy summing up some other work. I have been looking more in to the issue of MBeanFactory.The issue was caused by the fact that MBeanFactory itself being a BaseModelBean unlike other normal classes such as StandardService etc. Although it extends BaseModelBean it doesn't utilise any of its inherited methods and it being a BaseModelBean is not leveraged in any other point in the sources. So I suggest removing 'is a' relationship between MBeanFactory and BaseModelBean and make MBeanFactory a normal class which can be managed using a BaseModelBean object. It solves the issue that both managed resource and the mbean being instances of the same class, a situation which is unique to MBeanFactory. In this patch I have reversed the changes made to the modeler code in order to overcome the earlier issue. And additionally separate create method has been added to create an Engine component. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org