tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keiichi Fujino <kfuj...@apache.org>
Subject Re: svn commit: r933881 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
Date Thu, 15 Apr 2010 06:58:14 GMT
2010/4/14 Mladen Turk <mturk@apache.org>:
> On 04/14/2010 10:48 AM, kfujino@apache.org wrote:
>>
>> Author: kfujino
>>
>> Modified:
>>     tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
>>
>> +                        session.expire();
>> +                    }
>>                      sessionCounter++;
>
> Seems we are using the sessionCounter as well as expiredSessions
> just for the information purposes.
> Think they should be declared as long instead of int cause
> those values never gets reset and can only grow, eventually
> reaching the MAX_INT and going to negative values.
>
> Given that Tomcat can survive long enough to
> generate +2 billion sessions at the first place :)
>

OK.
I will declare only sessionCounter and expiredSessions as long instead of int.


-- 
Keiichi.Fujino

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message